[PATCH] D109823: [GlobalOpt] Do not shrink global to bool for an unfavorable AS

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/Transforms/GlobalOpt/shrink-global-to-bool.ll:14
+; CHECK: @lvar = internal unnamed_addr addrspace(3) global i32 undef
+; AMDGCN: @lvar = internal unnamed_addr addrspace(3) global i32 undef
+
----------------
jdoerfert wrote:
> Why is the check and amdgcn line the same, that I don't understand. Should it not trigger for "check"?
The host line won't fail the address space check, and it serves as a sanity check that the transform would be performed otherwise


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109823/new/

https://reviews.llvm.org/D109823