[PATCH] D108115: [llvm][sve] Lowering for VLS masked truncating stores

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 15 07:19:28 PDT 2021


dmgreen added a comment.

Thanks for fixing the MVE issues. Most of the changes here don't look SVE related, being generic DAG combines. It would probably be best to split them into a separate review to keep logically separable additions in different reviews in case there are issues with them.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9833
+    if (SDValue Shorter = DAG.GetDemandedBits(Value, TruncDemandedBits))
+      return DAG.getMaskedStore(Chain, SDLoc(N), Shorter, Ptr,
+                                MST->getOffset(), MST->getMask(),
----------------
Is this tested anywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108115/new/

https://reviews.llvm.org/D108115



More information about the llvm-commits mailing list