[PATCH] D109252: Add extra check for llvm::Any::TypeId visibility

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 15 02:49:41 PDT 2021


skatkov added inline comments.


================
Comment at: llvm/test/lit.cfg.py:243
 
+if config.link_llvm_dylib:
+    config.available_features.add('llvm-dylib')
----------------
skatkov wrote:
> I wonder whether config.build_shared_libs should be checked also to ensure that shared libraries built?
> 
> I've got an error on the added test by this commit due to shared library is not exist.
I used -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON to run cmake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109252/new/

https://reviews.llvm.org/D109252



More information about the llvm-commits mailing list