[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 15 01:47:38 PDT 2021


uweigand added a comment.

In D109362#3000284 <https://reviews.llvm.org/D109362#3000284>, @anirudhp wrote:

> In D109362#2999688 <https://reviews.llvm.org/D109362#2999688>, @uweigand wrote:
>
>> Looking at the common code parts, it seems the behavior of MM_GOFF is actually identical to MM_ELF.   Is this correct?   If so, do we really need a different format type here?
>
> At a future point, we will be changing the local and global prefixes. At that point we would still need a separate `MM_GOFF` field. I feel it would be a bit better to enforce it from now itself.

I see.  Is there a reason why we cannot use the "correct" prefixes to begin with?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109362/new/

https://reviews.llvm.org/D109362



More information about the llvm-commits mailing list