[PATCH] D109794: [Sanitizer] Allow setting the report path to create directory

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_file.cpp:92
+    path[i] = '\0';
+#if SANITIZER_WINDOWS
+    _mkdir(path);
----------------
to avoid #ifs here can you please create CreateDir() and provide two implementations:
in sanitizer_win and sanitizer_posix


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_file.cpp:98
+#endif
+    path[i] = save;
+  }
----------------
please clang-format as it asks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109794/new/

https://reviews.llvm.org/D109794