[PATCH] D109730: [lld][WebAssembly] Use llvm-objdump to test __wasm_init_memory

Tue Sep 14 15:16:48 PDT 2021

tlively added inline comments.

================
Comment at: lld/test/wasm/data-segments.ll:171
+; DIS-NEXT:                                            # 2:     down to label0
+; DIS-NEXT:            end
+
----------------
sbc100 wrote:
> Kind of shame there are so many differences here between the PIC/no-PIC and 64/32-bit.
> 
> Do you think this more useful than just having completely separate blocks (with duplication)?
> 
> I wonder if you could do -DINT=i32 / -DINT=i64 to remove at least one level of splitting here?
I removed one level of splitting, as you suggested. Let me know if you think it looks reasonable, otherwise I can fully duplicate the function between PIC and non-PIC code as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109730/new/

https://reviews.llvm.org/D109730