[PATCH] D109782: [SCEV] Stop applying contextual flags in applyLoopGuards

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

Thanks for fixing this! LGTM



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:13499
+    // WARNING: It is generally unsound to apply any wrap flags to the proposed
+    // replacement SCEV which isn't directly implied by the replacee SCEV.  In
+    // particular, using contextual facts to imply flags is *NOT* legal.  See
----------------
nit: replacee -> replaced?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109782/new/

https://reviews.llvm.org/D109782