[PATCH] D109252: Add extra check for llvm::Any::TypeId visibility

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/tools/llvm-shlib/typeids.test:10
+# RUN: llvm-nm -C %llvmdylib | FileCheck %s --check-prefix=SAFETY-CHECK
+#
+# CHECK-NOT: {{[^V]}} llvm::Any::TypeId
----------------
Don't use `#` for blank lines.


================
Comment at: llvm/test/tools/llvm-shlib/typeids.test:14
+#
+# REQUIRES: x86_64-linux, llvm-dylib
----------------
It is more common to place `REQUIRES:` at the top.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109252/new/

https://reviews.llvm.org/D109252