[PATCH] D109748: [GlobalISel][Legalizer] Use ArtifactValueFinder first for unmerge combines before trying others.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 11:28:26 PDT 2021


aemerson added a comment.

In D109748#2999614 <https://reviews.llvm.org/D109748#2999614>, @arsenm wrote:

> The MIR test changes are all clearly worse, but the IR tests are small improvements. The MIR tests all look like unfortunate legalization ordering changes that just result in more artifact churn (some of which should result in more instructions in the end). This is probably from no longer considering the legalization action of the proposed new unmerge. I'm not really sure what to do here. I'm still not 100% clear on how artifact legalization rules should be used, and whether the artifact combiner should be fully responsible for handling them

Can these regressions be cleaned up by a later (postlegalize) combine for AMDGPU?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109748/new/

https://reviews.llvm.org/D109748



More information about the llvm-commits mailing list