[PATCH] D109767: [update_mir_test_checks.py] Use -NEXT FileCheck directories

[Alexander Richardson via Phabricator via llvm-commits]

arichardson created this revision.
Herald added a subscriber: pengfei.
arichardson edited the summary of this revision.
arichardson added reviewers: bogner, MaskRay, lebedev.ri.
arichardson published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously the script emitted output using plain CHECK directives. This
can result in a test passing even if there are some instructions between
CHECK directives that should have been removed. It also makes debugging
tests that have the output in a different order more difficult since
FileCheck can match with a later line and then complain about the "wrong"
directive not being found.

This will cause quite large diffs when updating existing tests, but I'm not sure we need an opt-in flag here.

Depends on D109765 <https://reviews.llvm.org/D109765> (pre-commit tests)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109767

Files:
  llvm/test/CodeGen/X86/GlobalISel/select-phi.mir
  llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/x86-condbr.mir.expected
  llvm/utils/update_mir_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109767.372499.patch
Type: text/x-patch
Size: 16591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210914/90029c90/attachment.bin>