[PATCH] D109450: [IRSim][IROutliner] Allowing Intrinsic Calls to be Used in Similarity Matching and Outlined Regions

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:226
           llvm::hash_combine_range(OperTypes.begin(), OperTypes.end()));
-    else if (CallInst *CI = dyn_cast<CallInst>(ID.Inst))
+    else if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(ID.Inst)) {
+      Intrinsic::ID IntrinsicID = II->getIntrinsicID();
----------------
can you add some comments?


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:497
+    InstrType visitIntrinsicInst(IntrinsicInst &II) {
+      if (II.isLifetimeStartOrEnd() || II.isAssumeLikeIntrinsic())
+        return Illegal;
----------------
add comments for why these are disabled?


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:522
+    // The flag variable that lets the classifier know whether we should
+    // allow intrinsics to be checked for similarity.
+    bool EnableIntrinsics = false;
----------------
this comment can probably be simplified


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109450/new/

https://reviews.llvm.org/D109450