[PATCH] D108512: [flang][OpenMP] Add semantic checks for ordered construct

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. A question and a comment.

Thanks for this work. Please submit with @sameeranjoshi as co-author. Please wait a day to see whether there are any other comments.



================
Comment at: test/Semantics/omp-ordered01.f90:2
+! RUN: %S/test_errors.sh %s %t %flang_fc1 -fopenmp
+! REQUIRES: shell
+
----------------
Nit: Remove the requires and switch to test_errors.py when you submit.


================
Comment at: test/Semantics/omp-ordered01.f90:51
+    arrayB(i) = bar(arrayA(i), arrayB(i-1))
+    !ERROR: No type declared for 'undecvar'
+    !ERROR: Only DEPEND(SOURCE) or DEPEND(SINK: vec) are allowed when ORDERED construct is a standalone construct with no ORDERED region
----------------
Nit: Is this required?
Can you use a defined variable in the depend(sink) clause?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108512/new/

https://reviews.llvm.org/D108512