[PATCH] D109737: [LTO] Emit DebugLoc for dead function in optimization remarks

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:860
       if (Function *F = dyn_cast<Function>(GV)) {
+        if (Error Err = F->materialize())
+          return Err;
----------------
Were we eventually materializing these dead functions without this change? If not, this seems like a compile time degradation. Would it work to move the materialize call later, capture the OptimizationRemark in a variable, and guard the materialization by isEnabled() on the remark?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109737/new/

https://reviews.llvm.org/D109737