[PATCH] D109523: [ARM] Remove isel patterns that start with (fneg (fma)).

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 07:53:09 PDT 2021


spatel added a reviewer: dmgreen.
spatel added a comment.

Echoing the comment in D109525 <https://reviews.llvm.org/D109525> - are there tests that include 'nsz' to confirm that we can still fold those patterns? 
This is fixing a miscompile, so we might not want to hold it up on an optimization, but it would be nice to salvage the transform if possible.



================
Comment at: llvm/test/CodeGen/ARM/fusedMAC.ll:16
+;
+; DONT-FUSE-LABEL: fusedMACTest1:
+; DONT-FUSE:       @ %bb.0:
----------------
Generate the full checks as a preliminary step, so we just see the diffs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109523/new/

https://reviews.llvm.org/D109523



More information about the llvm-commits mailing list