[PATCH] D109758: [StackColoring] Fix a debug invariance problem

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a reviewer: djtodoro.
bjope added inline comments.


================
Comment at: llvm/lib/CodeGen/StackColoring.cpp:715
         MarkersFound += 1;
-      } else {
+      } else if (!MI.isDebugInstr()) {
         for (const MachineOperand &MO : MI.operands()) {
----------------
djtodoro wrote:
> an early continue at the begging of the loop as:
> 
>     if (MI.isDebugInstr())
>       continue;
> ?
Thanks for taking a look (I haven't figured out whom to add as a reviewer yet, but maybe you are signing up as a volounteer)!

And sure, probably cleaner to add such an early continue to show that we ignore debug instructions throughout the analysis. I'll fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109758/new/

https://reviews.llvm.org/D109758