[PATCH] D109757: [StackColoring] Pre-commit of test case showing a debug invariance bug

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 06:28:50 PDT 2021


bjope created this revision.
Herald added a subscriber: pengfei.
bjope requested review of this revision.
Herald added a project: LLVM.

Having DBG_VALUE instructions referencing a stack slot while being outside
of the LIFETIME_START/LIFETIME_END markers for that stack slot is perhaps
not always ideal (from a debugging perspective), but it might happen during
codegen that we end up with such situations (e.g. positioning of the
DBG_VALUE instruction for a SDDbgOperand::FRAMEIX at ISel is a bit sloppy
in that context).

This patch adds a test case showing that StackColoring currently isn't
debug invariant, and that the position of DBG_VALUE instructions referencing
the stack slots might impact the decision making regarding stack slot reuse.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109757

Files:
  llvm/test/CodeGen/X86/StackColoring-dbg-invariance.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109757.372468.patch
Type: text/x-patch
Size: 5297 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210914/209d7db8/attachment-0001.bin>


More information about the llvm-commits mailing list