[PATCH] D109708: [Windows build] Use "DIA SDK" in sysroot
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 14 06:01:27 PDT 2021
thakis added a comment.
Thanks!
Turns out there was an existing tab character in llvm/cmake/config-ix.cmake too. I replaced that with spaces that in a preparatory commit.
================
Comment at: compiler-rt/cmake/config-ix.cmake:573
+ set(MSVC_DIA_SDK_DIR "${LLVM_WINSYSROOT}/DIA SDK" CACHE PATH
+ "Path to the DIA SDK")
+ else()
----------------
hans wrote:
> ultra nit: Indentation of the string looks off here and in the else branch. Same for the llvm/cmake/config-ix.cmake file.
It looks off in phab, but looks good in the raw diff…oh whoops, that's because the line starts with a tab. My bad, fixed.
(In addition to fixing my editor config, TIL about `git config core.whitespace tab-in-indent`.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109708/new/
https://reviews.llvm.org/D109708
More information about the llvm-commits
mailing list