[PATCH] D109754: AMDGPU: Use -1/0 when copying from SCC to SGPR

[Piotr Sobczak via Phabricator via llvm-commits]

piotr added a comment.

The change makes sense to me in general.

When I tried doing the same long time ago, Matt rightly pointed out (https://reviews.llvm.org/D81925#inline-753225) that sign extending does not correspond to the booleans being defined as zero extended. So, wouldn't your change also require an accompanying change of boolean contents to ZeroOrNegativeOneBooleanContent instead of ZeroOrOneBooleanContent in SIISelLowering.cpp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109754/new/

https://reviews.llvm.org/D109754