[PATCH] D109730: [lld][WebAssembly] Use llvm-objdump to test __wasm_init_memory

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 05:31:41 PDT 2021


sbc100 added inline comments.


================
Comment at: lld/test/wasm/data-segments.ll:171
+; DIS-NEXT:                                            # 2:     down to label0
+; DIS-NEXT:            end
+
----------------
Kind of shame there are so many differences here between the PIC/no-PIC and 64/32-bit.

Do you think this more useful than just having completely separate blocks (with duplication)?

I wonder if you could do -DINT=i32 / -DINT=i64 to remove at least one level of splitting here?


================
Comment at: lld/test/wasm/data-segments.ll:227
+; DIS-NEXT:          data.drop       1
+; DIS-NEXT:         end
----------------
We weren’t able to create the releas


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109730/new/

https://reviews.llvm.org/D109730



More information about the llvm-commits mailing list