[PATCH] D109708: [Windows build] Use "DIA SDK" in sysroot

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 01:53:58 PDT 2021


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: compiler-rt/cmake/config-ix.cmake:573
+    set(MSVC_DIA_SDK_DIR "${LLVM_WINSYSROOT}/DIA SDK" CACHE PATH
+	"Path to the DIA SDK")
+  else()
----------------
ultra nit: Indentation of the string looks off here and in the else branch. Same for the llvm/cmake/config-ix.cmake file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109708/new/

https://reviews.llvm.org/D109708



More information about the llvm-commits mailing list