[PATCH] D109729: [RISCV] Optimize (add (shl x, c0), (shl y, c1))

Mon Sep 13 21:26:16 PDT 2021

benshi001 added a comment.

In D109729#2998986 <https://reviews.llvm.org/D109729#2998986>, @craig.topper wrote:

> In D109729#2998980 <https://reviews.llvm.org/D109729#2998980>, @benshi001 wrote:
>
>> Using `let PredicateCodeUsesOperands = 1` makes code more boring and complex. So I have resorted to using DAG2GAG selection which looks more clear.
>
> I'm not sure what you mean by boring here. Can you share one of the PatFrags using that feature?

I mean the similar code is copied 6 times which is boring, and it becomes more complex than I expected. and I think using DAG2DAG is more clear.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109729/new/

https://reviews.llvm.org/D109729