[PATCH] D109594: [AMDGPU] Initialize LDS pointers after alloca, but before call.

Mon Sep 13 20:28:33 PDT 2021

hsmhsm added a comment.

In D109594#2998933 <https://reviews.llvm.org/D109594#2998933>, @arsenm wrote:

> Since this isn’t required for correctness, this should just skip the allocas clustered at the beginning. There’s no need to scan beyond or consider calls

That is what I did in the patch https://reviews.llvm.org/D108971 ,  and then after enabling this LDS pass at https://reviews.llvm.org/D109062, we got some OpenMP build-bot test failures, and I had to revert the patches.  So, I added code to scan alloca beyond  calls to avoid surprising failures. We really need to take this alloca stuff as a separate task, and I do not think we can do any quick fix for it. Until then, for LDS we need to live with this hack.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109594/new/

https://reviews.llvm.org/D109594