[PATCH] D109634: [LLD] Remove global state in lld/COFF

Mon Sep 13 16:12:25 PDT 2021

MaskRay added inline comments.

================
Comment at: lld/COFF/CMakeLists.txt:4
 add_public_tablegen_target(COFFOptionsTableGen)

 add_lld_library(lldCOFF
----------------
aganea wrote:
> Can the following be added here? What would be missing for this to work?
> ```
> # Enable errors for any global constructors.
> add_flag_if_supported("-Werror=global-constructors" WERROR_GLOBAL_CONSTRUCTOR)
> ```
i think the flag switch should be added separately. this can very easily break some builds for some platforms if there is some platform-specific `#ifdef`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109634/new/

https://reviews.llvm.org/D109634