[PATCH] D109669: [WebAssembly] Handle _setjmp and _longjmp in SjLj

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

otherwise LGTM



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:841
+    if (SetjmpF)
+      assert(SetjmpF->getFunctionType() == SetjmpF2->getFunctionType() &&
+             "setjmp and _setjmp have different function types");
----------------
Is there any way this can happen other than an LLVM bug (e.g. a library problem, or a user's function being used instead of a library function, etc)? If so, it should probably be a fatal error instead of an assert. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109669/new/

https://reviews.llvm.org/D109669