[PATCH] D109300: [AMDGPU] Make vector superclasses allocatable
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 13 13:26:37 PDT 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:2789
+ const TargetRegisterClass *RC = RI.getRegClassForReg(*MRI, DstReg);
+ bool IsVectorRegCopy = RI.hasVectorRegisters(RC);
+ unsigned NewOpc =
----------------
This logically doesn't flow right. This shouldn't be checking hasVectorRegisters, and just use isVGPR. You override this decision later with the AGPR class
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109300/new/
https://reviews.llvm.org/D109300
More information about the llvm-commits
mailing list