[PATCH] D109649: [llvm-readobj] [COFF] Try to resolve symbols in unwind info on x86

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/tools/llvm-readobj/Win64EHDumper.cpp:138
+    return Sym;
+  for (const auto &S : COFF.symbols()) {
+    COFFSymbolRef CS = COFF.getCOFFSymbol(S);
----------------
mstorsjo wrote:
> efriedma wrote:
> > Is repeatedly iterating over every symbol in the file going to cause performance issues?
> Yes if this would be performance sensitive, we probably should populate some different data structure for it - but I think it's not. The original code that looks up the relocation, by scanning linearly over all relocations in the object file until it hits one at the right section+offset, also does a similar order of magnitude of iterations.
I suspect we wouldn't notice even if there were performance issues: probably very few people use llvm-readobj on files of non-trivial size. I guess if you're not making the existing issues substantially worse, it's fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109649/new/

https://reviews.llvm.org/D109649