[PATCH] D109649: [llvm-readobj] [COFF] Try to resolve symbols in unwind info on x86

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 13 12:49:19 PDT 2021


efriedma added inline comments.


================
Comment at: llvm/tools/llvm-readobj/Win64EHDumper.cpp:138
+    return Sym;
+  for (const auto &S : COFF.symbols()) {
+    COFFSymbolRef CS = COFF.getCOFFSymbol(S);
----------------
Is repeatedly iterating over every symbol in the file going to cause performance issues?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109649/new/

https://reviews.llvm.org/D109649



More information about the llvm-commits mailing list