[PATCH] D109712: [Sparc] NFC: Remove unused tblgen template args

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes added a comment.

In D109712#2998121 <https://reviews.llvm.org/D109712#2998121>, @jrtc27 wrote:

> Please upload patches with full context in future (use arc diff to automate submitting to Phabricator, or pass -U99999 to git)

Apologies I usually do, I've re-uploaded the patch with full context.



================
Comment at: llvm/lib/Target/Sparc/SparcInstrInfo.td:372
 // CodeGen's address spaces to use these is a future task.
-class LoadASI<string OpcStr, bits<6> Op3Val, SDPatternOperator OpNode,
-              RegisterClass RC, ValueType Ty, InstrItinClass itin = NoItinerary> :
+class LoadASI<string OpcStr, bits<6> Op3Val, RegisterClass RC> :
   F3_1_asi<3, Op3Val, (outs RC:$dst), (ins MEMrr:$addr, i8imm:$asi),
----------------
jrtc27 wrote:
> Aren't these arguments specifically for when the TODO gets addressed? I think it makes more sense to keep them...
> Aren't these arguments specifically for when the TODO gets addressed? I think it makes more sense to keep them...

Yeah, although they could also be added when the TODO gets addressed? FWIW, the TODO has been there for 6 years.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109712/new/

https://reviews.llvm.org/D109712