[PATCH] D109712: [Sparc] NFC: Remove unused tblgen template args
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 13 11:41:31 PDT 2021
jrtc27 added a comment.
Please upload patches with full context in future (use arc diff to automate submitting to Phabricator, or pass -U99999 to git)
================
Comment at: llvm/lib/Target/Sparc/SparcInstrInfo.td:372
// CodeGen's address spaces to use these is a future task.
-class LoadASI<string OpcStr, bits<6> Op3Val, SDPatternOperator OpNode,
- RegisterClass RC, ValueType Ty, InstrItinClass itin = NoItinerary> :
+class LoadASI<string OpcStr, bits<6> Op3Val, RegisterClass RC> :
F3_1_asi<3, Op3Val, (outs RC:$dst), (ins MEMrr:$addr, i8imm:$asi),
----------------
Aren't these arguments specifically for when the TODO gets addressed? I think it makes more sense to keep them...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109712/new/
https://reviews.llvm.org/D109712
More information about the llvm-commits
mailing list