[PATCH] D108507: [NFC][LoopIdiom] Add more test case to runtime-determined memset size

Mon Sep 13 11:36:56 PDT 2021

bmahjour added inline comments.

================
Comment at: llvm/test/Transforms/LoopIdiom/memset-runtime-64bit.ll:17
+; }
+define dso_local void @PositiveFor64(i32* %ar, i64 %n, i64 %m) {
+; CHECK-LABEL: @PositiveFor64(
----------------
For better coverage, we should also test with `long long` loop bounds in 32-bit mode and `int` bounds in 64-bit mode.

================
Comment at: llvm/test/Transforms/LoopIdiom/memset-runtime.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt -passes="function(loop(loop-idiom,loop-deletion),simplifycfg)" -S < %s | FileCheck %s
----------------
What's the dependency between this patch and D108112? Should we expect to see the updates made to `memset-runtime.ll` under that patch to apply on top of this change?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108507/new/

https://reviews.llvm.org/D108507