[PATCH] D109708: [Windows build] Use "DIA SDK" in sysroot

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: hans.
Herald added subscribers: hiraditya, mgorny.
thakis requested review of this revision.
Herald added a project: LLVM.

This updates llvm/utils/sysroot.py to include the "DIA SDK" folder in the sysroot.

It also updates the build to look for the DIA SDK there if a sysroot is set.

This requires moving LLVM_WINSYSROOT to config-ix.cmake.

For the GN build, I chose to pass a qualified path to diaguids in libs instead of pushing
a config with a `/libpath:` flag. The former requires a GN with
https://gn-review.googlesource.com/c/gn/+/12200, the latter requires D109624 <https://reviews.llvm.org/D109624>. The former is
more like the cmake build, arguably a bit simpler, and it's easier to check
for the wrong GN revision and easier to update GN.


https://reviews.llvm.org/D109708

Files:
  compiler-rt/cmake/config-ix.cmake
  llvm/cmake/config-ix.cmake
  llvm/cmake/modules/HandleLLVMOptions.cmake
  llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn
  llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/enable_dia.gni
  llvm/utils/sysroot.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109708.372296.patch
Type: text/x-patch
Size: 6024 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210913/7c33b15d/attachment.bin>