[PATCH] D109594: [AMDGPU] Initialize LDS pointers after alloca, but before call.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 13 10:58:11 PDT 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUReplaceLDSUseWithPointer.cpp:443
+ ++KI) {
+ if (hasAllocaAfterCall(KI->first))
+ return false;
----------------
I don't like this arbitrary condition. Why not just collect all allocas and re-insert them at the start of the entry block?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109594/new/
https://reviews.llvm.org/D109594
More information about the llvm-commits
mailing list