[PATCH] D109114: [GlobalDCE] Add a mode to VFE that replaces unused vtable slots with a trap function instead of a NULL pointer

Mon Sep 13 10:34:43 PDT 2021

fhahn added a comment.

In D109114#2980673 <https://reviews.llvm.org/D109114#2980673>, @pcc wrote:

> It doesn't seem too bad to look through the use list to find any ptrtoint references and then any sub references. At that point you can replace with 0, no need to look for the trunc as well.

This sounds like a good option to me as well!

================
Comment at: llvm/test/Transforms/GlobalDCE/virtual-functions-trap.ll:4
+; RUN: opt < %s -globaldce -globaldce -globaldce -S | FileCheck %s
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
can you add a comment why there are multiple run lines with different numbers of `globaldce` invocations?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109114/new/

https://reviews.llvm.org/D109114