[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

Mon Sep 13 09:14:14 PDT 2021

MaskRay added a comment.

In D104556#2997674 <https://reviews.llvm.org/D104556#2997674>, @catenacyber wrote:

> This commit has broken oss-fuzz workflow for rust projects.
> I do not know if the fix is https://reviews.llvm.org/rG66e2772e4285588ccc3bcdb5f392c8326debbd7d
>
> Scenario is
>
>   export RUSTFLAGS="--cfg fuzzing -Cdebuginfo=1 -Cforce-frame-pointers -Zinstrument-coverage -C link-dead-code -C link-arg=-lc++"
>   git clone https://github.com/ctz/rustls && cd rustls
>   cargo fuzz build -O
>   ./fuzz/target/x86_64-unknown-linux-gnu/release/client ./fuzz/target/x86_64-unknown-linux-gnu/release/client
>   llvm-profdata merge -sparse default.profraw -o profdata
>
> Current output is
>
>   warning: default.profraw: malformed instrumentation profile data
>   error: no profile can be merged
>
> Scenario does not output error for in 13.0.0-rc2
>
> Error does not happen on commit 69cdadddecaf97f572c311aa07044f79a5b8329a <https://reviews.llvm.org/rG69cdadddecaf97f572c311aa07044f79a5b8329a> just previous this integration, if we add `git cherry-pick a6c14fba70e170a279f7e77f068368f09d8c5eaf` to fix the other pending bug which was fixed in 13.0.0-rc2
> Error happens on commit a1532ed27582038e2d9588108ba0fe8237f01844 <https://reviews.llvm.org/rGa1532ed27582038e2d9588108ba0fe8237f01844> even if we `git cherry-pick a6c14fba70e170a279f7e77f068368f09d8c5eaf` and fix the conflict about only llvm/test/tools/llvm-profdata/Inputs/c-general.profraw

I don't think this change is responsible. This has been used by many C++ downstream groups.

Rust should use upgrade its lib/ProfileData and compiler-rt/lib/profile.
The binary ID change has caused a bit of churn to ProfileData but it is unrelated to this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104556/new/

https://reviews.llvm.org/D104556