[PATCH] D109700: [InstCombine] Improve TryToSinkInstruction with multiple uses

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 13 09:09:06 PDT 2021


anna added inline comments.


================
Comment at: llvm/include/llvm/IR/Value.h:458
-  ///
-  /// This is specialized because it is a common request and does not require
-  /// traversing the whole use list.
----------------
This comment wasn't true even before the patch. We are traversing the entire use list here to find the "non-droppable use".  I can land this separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109700/new/

https://reviews.llvm.org/D109700



More information about the llvm-commits mailing list