[PATCH] D109661: [FunctionPropertiesAnalysis] Add `PreciseFunctionPropertiesAnalysis`

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/include/llvm/Analysis/FunctionPropertiesAnalysis.h:85
 
+class PreciseFunctionPropertiesInfo {
+public:
----------------
Nit: Is it "Precise" or "Detailed"?


================
Comment at: llvm/include/llvm/Analysis/FunctionPropertiesAnalysis.h:101
+  // Number of Basic Blocks.
+  int64_t BasicBlockCount = 0;
+
----------------
please expose these through a getter, and hide the setter. It simplifies maintenance - easier to read and reason about code when it's easy to find where state can be mutated 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109661/new/

https://reviews.llvm.org/D109661