[PATCH] D109500: [openmp] Fix 51647, corrupt bitcode on amdgpu

Mon Sep 13 06:23:57 PDT 2021

JonChesterfield added inline comments.

================
Comment at: llvm/test/Transforms/OpenMP/custom_state_machines.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --include-generated-funcs
+; RUN: opt --mtriple=amdgcn-amd-amdhsa -S -passes=openmp-opt < %s | FileCheck %s --check-prefixes=ALL,AMDGPU
----------------
Changed the opt invocations here. Now have one opt for mtriple=amdgpu and one for nvptx, with CHECK-PREFIXES set.

Then ran (exactly):
cd $HOME/llvm-project/llvm
./utils/update_test_checks.py test/Transforms/OpenMP/custom_state_machines.ll --opt-binary=$HOME/llvm-install/bin/opt

That rewrite custom_state_machines to what is uploaded here, which seems unlikely to be what is desired. It looks like a complete copy of the input duplicated for each permutation of check-prefixes, plus all the CHECK-NEXT from before which is now dead.

What am I supposed to do to update this test?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109500/new/

https://reviews.llvm.org/D109500