[PATCH] D109444: [LV] Don't vectorize if we can prove RT + vector cost >= scalar cost (alt. version)

Mon Sep 13 05:44:32 PDT 2021

lebedev.ri added a comment.

In D109444#2997214 <https://reviews.llvm.org/D109444#2997214>, @ebrevnov wrote:

> In D109444#2989903 <https://reviews.llvm.org/D109444#2989903>, @lebedev.ri wrote:
>
>> Suppose D109368 <https://reviews.llvm.org/D109368> lands first.
>> Is this particular patch an NFC change, or a functional-one?
>> What i'm asking is, where does this matter?
>> Can you add tests where the cost of the checks will be radically different for different VF's?
>
> I greatly reworked this patch since the original questions so not sure if it still matters....Anyway the intention of this patch was to replace D109368 <https://reviews.llvm.org/D109368>. It achieves the same effect by a slightly different way. Namely cost of runtime checks are embedded into main step of cost calculation. Note that we still can land D109368 <https://reviews.llvm.org/D109368> first and apply this one later (rebase required)

I'm not sure this answered my question.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109444/new/

https://reviews.llvm.org/D109444