[PATCH] D109660: [SystemZ] Recognize .machine directive in parser.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 13 04:17:10 PDT 2021


uweigand added a comment.

> Does such a directive need to be output again from the parser in case output is back into textual form (filetype=asm)? This is currently not done by the patch - I see that these are dropped after running GAS | objdump... (object format). I guess in that case either MCTargetStreamer is needed, or possibly some RawText emission..?

I think for consistency the .machine should be output again.   It's probably best to add a MCTargetStreamer now, sooner or later we'll probably need one anyway.  (This may also help with implementing EXRL templates via the constant pool mechanism as discussed elsewhere ...)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109660/new/

https://reviews.llvm.org/D109660



More information about the llvm-commits mailing list