[PATCH] D109657: [SystemZ] Accept plain register name where an address is expected.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 13 04:02:23 PDT 2021


uweigand added a comment.

> This patch is not checking the expected kind of address (MemKind) or HasLength / HasVectorIndex - would that be better?

I believe %reg should be treated equivalently to 0(%reg) for any type of address, including those with length or vector index, so this should be fine.   However, it would be good to validate that behavior against GAS, and also add a few test cases for instructions with those address types.

Otherwise the patch looks good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109657/new/

https://reviews.llvm.org/D109657



More information about the llvm-commits mailing list