[PATCH] D107580: [VectorCombine] Support AND/UREM indices that require freezing.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:785-786
+
+  ScalarizationResult(StatusTy S, Value *ToFreeze = nullptr)
+      : Status(S), ToFreeze(ToFreeze) {}
+
----------------
lebedev.ri wrote:
> maybe
I think for constructors it is quite common to have names matching the directly initialized fields for arguments. To make things consistent for the constructor, I renamed to `S` argument to `Status`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107580/new/

https://reviews.llvm.org/D107580