[PATCH] D109646: [LNICM] Fix the crashing problem
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 13 01:51:51 PDT 2021
fhahn requested changes to this revision.
fhahn added a comment.
This revision now requires changes to proceed.
Could you please describe the issue and fix in the pat h description? Is there anything we can do to proactively check for similar issues in the LICM code? Originally there were very few places which required special handling for the loop-nest mode, but now it seems more widespread changes might be necessary.
================
Comment at: llvm/test/Transforms/LICM/lnicm-crash.ll:4
+
+define void @main() {
+entry:
----------------
it would be good to check for something other than just the return code in this test. Also, can you clean up the basic block names and maybe get rid of the unreachable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109646/new/
https://reviews.llvm.org/D109646
More information about the llvm-commits
mailing list