[PATCH] D107016: [DebugInfo][LoopStrengthReduction] Ensure restoration of cached DIExpression when using SCEV-based salvaging

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 13 01:40:26 PDT 2021


StephenTozer added a comment.

Agreed with the above - if the metadata turns out to be a huge pain to strip then I don't think it should be a blocker, but if Orlando's suggestions work (or anyone else has a good idea of how to do so) then we should use them. No further complaints from me (Orlando's comments aside), so LGTM once the others have had a fair chance to check the review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107016/new/

https://reviews.llvm.org/D107016



More information about the llvm-commits mailing list