[PATCH] D109650: [llvm-readobj] [COFF] Resolve relocations pointing at section symbols for arm64 too

Mon Sep 13 01:08:45 PDT 2021

jhenderson added a comment.

Couple of minor comments, since my Herald rule added me, but @rnk should do the real review.

================
Comment at: llvm/test/tools/llvm-readobj/COFF/arm64-unwind-preferred-symbol2.yaml:18
+    Alignment:       4
+    SectionData:     FE0F1FF8E133009100000094FE0741F8C0035FD6FF8300D1F60B00F9FE0F00F9E1330091E0031FAA00000094FE0F40F9F60B40F9FF830091C0035FD6
+    Relocations:
----------------
I've not got much experience with yaml2obj for COFF, but is this reasonably minimal? It looks like a lot of data, for what looks like a fairly small piece of testing.

================
Comment at: llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp:292
+
+    if (FunctionOnly) // Resolve label/section symbols into function names
+      SymOrErr = getPreferredSymbol(COFF, *SymOrErr, SymbolOffset);
----------------
Nit: add missing full stop whilst you're moving this comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109650/new/

https://reviews.llvm.org/D109650