[PATCH] D109631: [HardwareLoops] Loop guard intrinsic to recognise zext

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 13 00:19:55 PDT 2021


samparker added inline comments.


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:369
+  // Check if Count is a zext.
+  Value *CountBefZext =
+      isa<ZExtInst>(Count) ? cast<ZExtInst>(Count)->getOperand(0) : nullptr;
----------------
Can we use SCEV isLoopEntryGuardedByCond instead of doing the pattern matching? It feels like we should be able to replace IsCompareZero with it which would remove the need to do an explicit zext check. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109631/new/

https://reviews.llvm.org/D109631



More information about the llvm-commits mailing list