[PATCH] D109661: [FunctionPropertiesAnalysis] Add `PreciseFunctionPropertiesAnalysis`

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D109661#2996443 <https://reviews.llvm.org/D109661#2996443>, @uenoku wrote:

> @jdoerfert @mtrofin 
> Currently, I created a new pass because I'm not sure additional costs to calculates new features are affordable at MLInliner. 
> I'd like to put new features on `FunctionPropertiesInfo` if computational costs don't matter.

We could always make it an argument for the pass, e.g., when you create it you select the precision. Or, a command line option to get higher/lower precision. I think by default it should track all features and we can have subsets defined in a command line option if necessary. So if a user wants only 10 of the 40 features they add a selector into a command line enum and use it to skip features.

Wdyt?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109661/new/

https://reviews.llvm.org/D109661