[PATCH] D109566: [yaml2obj][XCOFF] add the SectionIndex field for symbol.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 12 08:42:04 PDT 2021


Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:325
+    if (YamlSym.SectionName) {
+      if (SectionIndexMap.find(*YamlSym.SectionName) == SectionIndexMap.end()) {
+        ErrHandler("the SectionName " + *YamlSym.SectionName +
----------------



================
Comment at: llvm/test/tools/yaml2obj/XCOFF/symbol-section.yaml:73
+
+# CASE4: Invalid section index
+
----------------
It might be good to report the invalid section index in the error message. e.g.,

```
the SectionIndex 2 specified in the symbol is invalid.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109566/new/

https://reviews.llvm.org/D109566



More information about the llvm-commits mailing list