[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 11 10:30:39 PDT 2021


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

In D109624#2995336 <https://reviews.llvm.org/D109624#2995336>, @thakis wrote:

>> I wonder if there are deeper reasons for GCC and Clang's current behaviour than early diagnosis and slightly nicer error messages.
>
> One easy way to find out is land this and if it breaks something, add a comment and a test for the next person :)
>
>> Since cl.exe seems to match the behaviour your patch is switching to, maybe we should only do this in clang-cl mode?
>
> Maybe! But the current behavior is arguably wrong for the `clang -fuse-ld=lld -Wl,-chroot,some/path /foo.o` case, so maybe we should try changing both for starters and then row back if needed?

Sounds good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109624/new/

https://reviews.llvm.org/D109624



More information about the llvm-commits mailing list