[PATCH] D109595: [WebAssembly] Convert to new "dylink.0" section format

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 11 03:45:29 PDT 2021


sbc100 added inline comments.


================
Comment at: llvm/tools/obj2yaml/wasm2yaml.cpp:54
   std::unique_ptr<WasmYAML::CustomSection> CustomSec;
-  if (WasmSec.Name == "dylink") {
+  if (WasmSec.Name == "dylink" || WasmSec.Name == "dylink.0") {
     std::unique_ptr<WasmYAML::DylinkSection> DylinkSec =
----------------
dschuff wrote:
> So wasm2yaml will accept either name. Does work because the parsing goes through lib/Object, which knows how to handle the legacy section format?
Yes version are supported for now.  And yes `lib/Object` hides the differences and exposes the same struct whichever version is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109595/new/

https://reviews.llvm.org/D109595



More information about the llvm-commits mailing list