[PATCH] D109551: [AutoFDO][llvm-profgen] Profile generation for LBR(non-CS) sample

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:290
-
-    // Disjoint ranges may have range in the middle of two instr,
-    // e.g. If Instr1 at Addr1, and Instr2 at Addr2, disjoint range
----------------
may still be good to keep the comment.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.h:25
 
 class ProfileGenerator {
 
----------------
Since we are now using this base class to generate non-CS non-probe profile, add a header comment to clarify that?


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.h:61
+  // FunctionProfile
+  void updateBodySamplesforFunctionProfile(FunctionSamples &FunctionProfile,
+                                           const SampleContextFrame &LeafLoc,
----------------
Make these new functions private since they are not supposed to be called by the derived classes?


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.h:65
+  FunctionSamples &getTopLevelFunctionProfile(StringRef FuncName);
+  // A help function to get the leaf frame's FunctionProfile by traversing the
+  // inline stack and meanwhile it adds the total samples for each frame's
----------------
Nit: a helper function ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109551/new/

https://reviews.llvm.org/D109551